Add read-only discovery workflows#111
Open
juliamuiruri4 wants to merge 3 commits into
Open
Conversation
Define five manual Quest Master workflows with fixed evidence boundaries and staged outputs. Extend validation to enforce topology, permissions, and compiler guards. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Print compiler changes when lock synchronization fails so platform-specific output can be diagnosed from the job log. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Expose the read-only job token to gh-aw so generated action references resolve consistently with committed lock files. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Phase 1, manually dispatched “Quest Master” discovery workflows intended to collect bounded, read-only evidence for specific quests, along with validation guards to ensure workflows remain manual-only, read-only, and topology/source constrained.
Changes:
- Added five
workflow_dispatchdiscovery workflow definitions (discover-*.md) plus their compiled.lock.ymlcounterparts and shared read-only discovery policy. - Added five non-invocable Quest Master agent profiles (
*.agent.md) that fix approved sources, owned paths, and stop conditions per quest. - Extended the repo’s validation script and CI workflow to validate the discovery policy/workflow topology and improve diagnostics for lock-file drift.
Show a summary per file
| File | Description |
|---|---|
| scripts/validate-refresh-config.mjs | Adds validators for the shared discovery policy and the five Phase 1 discovery workflows (sources/domains/topology/permissions/safe-outputs staging). |
| .github/workflows/validate-agentic-workflows.yml | Ensures gh aw compile has a token available and prints diffs when generated locks drift. |
| .github/workflows/shared/discovery-policy.md | Introduces a shared read-only tool/network policy and explicit “no-change/blocked” outcomes for Phase 1 discovery. |
| .github/workflows/discover-foundry-local.md | Adds manual-only discovery workflow definition for the Foundry Local quest. |
| .github/workflows/discover-foundry-local.lock.yml | Adds compiled lock workflow for Foundry Local discovery. |
| .github/workflows/discover-microsoft-foundry.md | Adds manual-only discovery workflow definition for the Microsoft Foundry quest. |
| .github/workflows/discover-microsoft-foundry.lock.yml | Adds compiled lock workflow for Microsoft Foundry discovery. |
| .github/workflows/discover-agentic-rag.md | Adds manual-only discovery workflow definition for the Agentic RAG quest (includes external CodeTour auditing). |
| .github/workflows/discover-agentic-rag.lock.yml | Adds compiled lock workflow for Agentic RAG discovery. |
| .github/workflows/discover-foundry-toolkit.md | Adds manual-only discovery workflow definition for the Foundry Toolkit quest. |
| .github/workflows/discover-foundry-toolkit.lock.yml | Adds compiled lock workflow for Foundry Toolkit discovery. |
| .github/workflows/discover-context-engineering.md | Adds manual-only discovery workflow definition for the Context Engineering quest (includes external CodeTour auditing). |
| .github/workflows/discover-context-engineering.lock.yml | Adds compiled lock workflow for Context Engineering discovery. |
| .github/agents/foundry-local-quest-master.agent.md | Adds Quest Master agent profile for Foundry Local (read-only, fixed sources/paths). |
| .github/agents/microsoft-foundry-quest-master.agent.md | Adds Quest Master agent profile for Microsoft Foundry (read-only, fixed sources/paths). |
| .github/agents/agentic-rag-quest-master.agent.md | Adds Quest Master agent profile for Agentic RAG (read-only, includes external CodeTour boundary). |
| .github/agents/foundry-toolkit-quest-master.agent.md | Adds Quest Master agent profile for Foundry Toolkit (read-only, fixed sources/paths). |
| .github/agents/context-engineering-quest-master.agent.md | Adds Quest Master agent profile for Context Engineering (read-only, includes external CodeTour boundary). |
| .github/workflows/shared/discovery-policy.md | Shared Phase 1 read-only discovery policy imported by all discovery workflows. |
| .github/aw/actions-lock.json | Adds an actions lock registry for pinned action SHAs used by workflows. |
| .github/dependabot.yml | Updates Dependabot config to ignore github/gh-aw-actions/** updates (managed by gh-aw compiler). |
| .github/agentic-refresh/README.md | Documents Phase 1 read-only discovery workflows and the staged safe-output/permission rationale. |
| .github/agentic-refresh/governance.md | Adds Phase 1 compiler guard rationale and constraints (staged safe-outputs to avoid write perms). |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 22/22 changed files
- Comments generated: 2
- Review effort level: Low
Comment on lines
+821
to
+824
| const frontmatter = readFrontmatter(workflowText, workflowPath); | ||
| const agentFrontmatter = readFrontmatter(agentText, agentPath); | ||
| const allowedDomains = readYamlList(frontmatter, "network:\\n allowed"); | ||
| const agentBlocks = [ |
Comment on lines
+2
to
+6
| - directory: / | ||
| ignore: | ||
| - dependency-name: "github/gh-aw-actions/**" # Managed by gh aw compile. Version-locked to the gh-aw compiler; do not bump. | ||
| package-ecosystem: github-actions | ||
| schedule: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack
Validation
gh aw compile --strict --validate --no-check-update --purgenode scripts/validate-refresh-config.mjsnode scripts/validate-content-links.mjsmkdocs build --strict